This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmetral
force-pushed
the
gatsby-v4
branch
from
November 9, 2021 05:41
74fa481
to
91b4858
Compare
BREAKING: requires Gatsby ^4.0.1
gatsby ^4.0.1 should only be a peer dependency
This commit alsp improves types and error reporting
Gatsby dropped support for Node <14 in v4 so we're doing the same. This commit switches to the recommended tsconfig from @tsconfig/node14 and addresses TS issues.
robinmetral
force-pushed
the
gatsby-v4
branch
from
November 17, 2021 11:11
ca7fbf6
to
783148d
Compare
robinmetral
commented
Nov 17, 2021
"react": "^17.0.2", | ||
"react-dom": "^17.0.2" | ||
}, | ||
"scripts": { | ||
"develop": "gatsby develop", | ||
"build": "gatsby build", | ||
"build": "gatsby build --verbose", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is sensible to keep for the example site since it helps with debugging any issue in the CI when the e2e tests are running on it
package.json
Outdated
"eslint": "^8.2.0", | ||
"eslint-config-prettier": "^8.3.0", | ||
"eslint-plugin-prettier": "^4.0.0", | ||
"gatsby": "^3.14.3", | ||
"gatsby": "^4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a devDependency because the interfaces we need to type the Gatsby Node APIs are coming from the gatsby package 😕
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to Gatsby v4.
If your site is still on Gatsby v3, please continue using
v2.1.2
until you've migrated.Closes #537
Closes #536