Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schedule hint support in volume resource #24

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

freesky-edward
Copy link

Use Case

The OpenStack cinder supports to add schedule parameters when creating
volume, the name of the parameters in API doc is "OS-SCH-HNT:scheduler_hints"
that can be found in Cinder API document here
In some cases, the user wish to set the parameters to fix the volume location.
this PR is to propose to add this parameter support in otc provider.

Propose To Change

In order to support this paramter, these parties need to change:

  1. Add the parameter support in Gophercloud SDKs
  2. Add the configuration parameter in provider
  3. Add the parameter vonverting when volume creation.

#1. please review gator1/gophercloud#8
#2 #3 are here.

Impact Anlysis

All configurations that end users had will work as they did.
Only to add following parties when the scenario need this party

resource "opentelekomcloud_blockstorage_volume_v2" "volume_fe01_01" {
name = "lizhonghua_test"
size = 10
availability_zone = "eu-de-01"
schedule_hint {
HOST = "cinder-kvm001@SATA#0"
}

}

This addition will not impact other resources as it is only a single
addition for volume creation.

Acceptance Test

All tests related this part passed, the log as follow:
=== RUN TestAccBlockStorageV2Volume_importBasic
--- PASS: TestAccBlockStorageV2Volume_importBasic (53.72s)
=== RUN TestAccBlockStorageV2Volume_basic
--- PASS: TestAccBlockStorageV2Volume_basic (164.38s)
=== RUN TestAccBlockStorageV2Volume_tags
--- PASS: TestAccBlockStorageV2Volume_tags (97.94s)
=== RUN TestAccBlockStorageV2Volume_image
--- PASS: TestAccBlockStorageV2Volume_image (211.33s)
=== RUN TestAccBlockStorageV2Volume_timeout
--- PASS: TestAccBlockStorageV2Volume_timeout (163.62s)

Resolves : #23

@gator1 gator1 merged commit b003eae into gator1:integration Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants