Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated compilation #49

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Fix duplicated compilation #49

merged 1 commit into from
Apr 7, 2020

Conversation

pdalpra
Copy link
Contributor

@pdalpra pdalpra commented Apr 7, 2020

No description provided.

Copy link
Member

@slandelle slandelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit message: "will still linking" => "while still linking"

@pdalpra pdalpra force-pushed the fix-duplicated-compilation branch from dec05d6 to 8115ae5 Compare April 7, 2020 14:11
…uration, close gatling/gatling#3490

This is caused by the `gatling` configuration rewiring too much of the
test settings into its configuration, while still linking some of its
setting to the `test` configuration.
This PR replaces `Defaults.testSettings` by `Defaults.testTasks`, which
wires less settings into the `gatling` configuration while still
achieving what we require (eg. splitting Gatling simulations from other
unit tests and integration tests).
@pdalpra pdalpra force-pushed the fix-duplicated-compilation branch from 8115ae5 to 0afb0a3 Compare April 7, 2020 14:12
@pdalpra pdalpra merged commit b944ee3 into master Apr 7, 2020
@pdalpra pdalpra deleted the fix-duplicated-compilation branch April 7, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants