Enable HibernateHints.HINT_READ_ONLY hint to count() queries

This adds the HibernateHints.HINT_READ_ONLY to the `count()` calls. `count()` named queries are only set when the hint is not set through the `@NamedQuery` annotation - Fixes quarkusio#35978
gastaldi · Sep 19, 2023 · 8f57724 · 8f57724
1 parent 3bf8a5a
commit 8f57724
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/.../src/main/java/io/quarkus/hibernate/orm/panache/common/runtime/AbstractJpaOperations.java b/.../src/main/java/io/quarkus/hibernate/orm/panache/common/runtime/AbstractJpaOperations.java
@@ -16,6 +16,7 @@
 import jakarta.transaction.TransactionManager;
 
 import org.hibernate.Session;
+import org.hibernate.jpa.HibernateHints;
 
 import io.agroal.api.AgroalDataSource;
 import io.quarkus.agroal.DataSource;
@@ -320,20 +321,26 @@ public Stream<?> streamAll(Class<?> entityClass, Sort sort) {
     public long count(Class<?> entityClass) {
         return (long) getEntityManager(entityClass)
                 .createQuery("SELECT COUNT(*) FROM " + PanacheJpaUtil.getEntityName(entityClass))
+                .setHint(HibernateHints.HINT_READ_ONLY, true)
                 .getSingleResult();
     }
 
     public long count(Class<?> entityClass, String panacheQuery, Object... params) {
         if (PanacheJpaUtil.isNamedQuery(panacheQuery)) {
             Query namedQuery = extractNamedQuery(entityClass, panacheQuery);
+            if (!namedQuery.getHints().containsKey(HibernateHints.HINT_READ_ONLY)) {
+                namedQuery.setHint(HibernateHints.HINT_READ_ONLY, true);
+            }
             return (long) bindParameters(namedQuery, params).getSingleResult();
         }
 
         try {
             return (long) bindParameters(
                     getEntityManager(entityClass)
                             .createQuery(PanacheJpaUtil.createCountQuery(entityClass, panacheQuery, paramCount(params))),
-                    params).getSingleResult();
+                    params)
+                    .setHint(HibernateHints.HINT_READ_ONLY, true)
+                    .getSingleResult();
         } catch (IllegalArgumentException x) {
             throw NamedQueryUtil.checkForNamedQueryMistake(x, panacheQuery);
         }
@@ -342,14 +349,19 @@ public long count(Class<?> entityClass, String panacheQuery, Object... params) {
     public long count(Class<?> entityClass, String panacheQuery, Map<String, Object> params) {
         if (PanacheJpaUtil.isNamedQuery(panacheQuery)) {
             Query namedQuery = extractNamedQuery(entityClass, panacheQuery);
+            if (!namedQuery.getHints().containsKey(HibernateHints.HINT_READ_ONLY)) {
+                namedQuery.setHint(HibernateHints.HINT_READ_ONLY, true);
+            }
             return (long) bindParameters(namedQuery, params).getSingleResult();
         }
 
         try {
             return (long) bindParameters(
                     getEntityManager(entityClass)
                             .createQuery(PanacheJpaUtil.createCountQuery(entityClass, panacheQuery, paramCount(params))),
-                    params).getSingleResult();
+                    params)
+                    .setHint(HibernateHints.HINT_READ_ONLY, true)
+                    .getSingleResult();
         } catch (IllegalArgumentException x) {
             throw NamedQueryUtil.checkForNamedQueryMistake(x, panacheQuery);
         }