Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IntelliJ 2022.x #17

Merged
merged 6 commits into from
Jun 25, 2022

Conversation

agatti
Copy link
Contributor

@agatti agatti commented May 15, 2022

IntelliJ 2022 and later need a few changes here and there to be able to even get the plugin built for those versions.

This PR contains the necessary changes to have the plugin build and run under IntelliJ 2022.1 - I don't have an older version installed to see if this breaks anything. It shouldn't, though.

@agatti
Copy link
Contributor Author

agatti commented May 15, 2022

Oh well, some UI changes do not work with earlier versions of IntelliJ 2021.x - I've reverted those. The rest should still be fine.

@garyttierney
Copy link
Owner

Hey, thanks for handling the upgrade. I'm just figuring out what the plugin verifier is complaining about and I'll get it merged.

@ekilmer
Copy link
Contributor

ekilmer commented Jun 23, 2022

@garyttierney After reading the errors and testing locally, this patch should fix CI:

diff --git a/src/main/kotlin/com/codingmates/ghidra/intellij/ide/facet/GhidraFacet.kt b/src/main/kotlin/com/codingmates/ghidra/intellij/ide/facet/GhidraFacet.kt
index 07c74d0..69f1fed 100644
--- a/src/main/kotlin/com/codingmates/ghidra/intellij/ide/facet/GhidraFacet.kt
+++ b/src/main/kotlin/com/codingmates/ghidra/intellij/ide/facet/GhidraFacet.kt
@@ -31,6 +31,21 @@ class GhidraFacet(
                 removeLibrary()
             }
 
+            override fun beforeFacetAdded(facet: Facet<*>) {
+            }
+
+            override fun beforeFacetRenamed(facet: Facet<*>) {
+            }
+
+            override fun facetAdded(facet: Facet<*>) {
+            }
+
+            override fun facetRemoved(facet: Facet<*>) {
+            }
+
+            override fun facetRenamed(facet: Facet<*>, oldName: String) {
+            }
+
             override fun facetConfigurationChanged(facet: Facet<*>) {
                 updateLibrary()
             }

@agatti
Copy link
Contributor Author

agatti commented Jun 25, 2022

@ekilmer if you don't mind, I can add these myself and trigger a CI run that way...

@ekilmer
Copy link
Contributor

ekilmer commented Jun 25, 2022

@ekilmer if you don't mind, I can add these myself and trigger a CI run that way...

@agatti Go for it!

@garyttierney
Copy link
Owner

Ah, hm, it did turn out just to be the facet methods... sorry for the delay!

@garyttierney garyttierney merged commit 6db8d6c into garyttierney:main Jun 25, 2022
@agatti agatti deleted the intellij-2022 branch June 25, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants