Skip to content

Commit

Permalink
Move purgatory metrics to separate file (opensource4you#515)
Browse files Browse the repository at this point in the history
  • Loading branch information
chia7712 authored Jul 28, 2022
1 parent 9a7731e commit 4e787f9
Show file tree
Hide file tree
Showing 4 changed files with 120 additions and 55 deletions.
48 changes: 0 additions & 48 deletions app/src/main/java/org/astraea/app/metrics/KafkaMetrics.java
Original file line number Diff line number Diff line change
Expand Up @@ -158,54 +158,6 @@ public static long linuxDiskWriteBytes(MBeanClient mBeanClient) {
}
}

public enum Purgatory {
AlterAcls("AlterAcls"),
DeleteRecords("DeleteRecords"),
ElectLeader("ElectLeader"),
Fetch("Fetch"),
Heartbeat("Heartbeat"),
Produce("Produce"),
Rebalance("Rebalance");

private final String metricName;

Purgatory(String name) {
this.metricName = name;
}

public String metricName() {
return metricName;
}

public Collection<HasBeanObject> fetch(MBeanClient mBeanClient) {
return mBeanClient
.queryBeans(
BeanQuery.builder()
.domainName("kafka.server")
.property("type", "DelayedOperationPurgatory")
.property("delayedOperation", metricName)
.property("name", "PurgatorySize")
.build())
.stream()
.map(HasValue::of)
.collect(Collectors.toUnmodifiableList());
}

public int size(MBeanClient mBeanClient) {
return (int)
mBeanClient
.queryBean(
BeanQuery.builder()
.domainName("kafka.server")
.property("type", "DelayedOperationPurgatory")
.property("delayedOperation", this.name())
.property("name", "PurgatorySize")
.build())
.attributes()
.get("Value");
}
}

public enum Request {
Produce,
FetchConsumer,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.astraea.app.metrics.broker;

import java.util.Arrays;
import java.util.Collection;
import java.util.stream.Collectors;
import org.astraea.app.metrics.jmx.BeanObject;
import org.astraea.app.metrics.jmx.BeanQuery;
import org.astraea.app.metrics.jmx.MBeanClient;

public final class ServerMetrics {

public enum DelayedOperationPurgatory {
AlterAcls("AlterAcls"),
DeleteRecords("DeleteRecords"),
ElectLeader("ElectLeader"),
Fetch("Fetch"),
Heartbeat("Heartbeat"),
Produce("Produce"),
Rebalance("Rebalance");

private final String metricName;

DelayedOperationPurgatory(String name) {
this.metricName = name;
}

public String metricName() {
return metricName;
}

public Collection<Size> fetch(MBeanClient mBeanClient) {
return mBeanClient
.queryBeans(
BeanQuery.builder()
.domainName("kafka.server")
.property("type", "DelayedOperationPurgatory")
.property("delayedOperation", metricName)
.property("name", "PurgatorySize")
.build())
.stream()
.map(Size::new)
.collect(Collectors.toUnmodifiableList());
}

public static DelayedOperationPurgatory of(String metricName) {
return Arrays.stream(DelayedOperationPurgatory.values())
.filter(metric -> metric.metricName().equalsIgnoreCase(metricName))
.findFirst()
.orElseThrow(() -> new IllegalArgumentException("No such metric: " + metricName));
}

public static class Size implements HasValue {
private final BeanObject beanObject;

public Size(BeanObject beanObject) {
this.beanObject = beanObject;
}

public String metricsName() {
return beanObject().properties().get("delayedOperation");
}

public DelayedOperationPurgatory type() {
return DelayedOperationPurgatory.of(metricsName());
}

@Override
public BeanObject beanObject() {
return beanObject;
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,6 @@ void testRequestBrokerTopicMetrics(KafkaMetrics.BrokerTopic metric) {
assertDoesNotThrow(result::rateUnit);
}

@ParameterizedTest()
@EnumSource(value = KafkaMetrics.Purgatory.class)
void testPurgatorySize(KafkaMetrics.Purgatory request) {
// act assert type casting correct and field exists
assertDoesNotThrow(() -> request.size(mBeanClient));
}

@ParameterizedTest()
@EnumSource(value = KafkaMetrics.Request.class)
void testRequestTotalTimeMs(KafkaMetrics.Request request) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.astraea.app.metrics.broker;

import org.astraea.app.metrics.jmx.MBeanClient;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;

public class ServerMetricsTest {

@ParameterizedTest()
@EnumSource(value = ServerMetrics.DelayedOperationPurgatory.class)
void testPurgatorySize(ServerMetrics.DelayedOperationPurgatory request) {
request.fetch(MBeanClient.local()).forEach(s -> Assertions.assertTrue(s.value() >= 0));
}
}

0 comments on commit 4e787f9

Please sign in to comment.