SelectField now triggers on change consistently when using props.value

fixes mui#1608
garth · Sep 8, 2015 · ba9fad5 · ba9fad5
1 parent 82bc1cb
commit ba9fad5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/drop-down-menu.jsx b/src/drop-down-menu.jsx
@@ -281,12 +281,12 @@ let DropDownMenu = React.createClass({
   },
 
   _onMenuItemClick(e, key, payload) {
-    if (this.props.onChange && this.state.selectedIndex !== key) {
-      let selectedItem = this.props.menuItems[key];
-      if (selectedItem) {
-        e.target.value = selectedItem[this.props.valueMember];
-      }
+    let selectedItem = this.props.menuItems[key];
+    if (selectedItem) {
+      e.target.value = selectedItem[this.props.valueMember];
+    }
 
+    if (this.props.onChange && (this.state.selectedIndex !== key || e.target.value !== this.props.value)) {
       if (this.props.valueLink) {
         this.props.valueLink.requestChange(e.target.value);
       }