Allow nested selectors

[jsakas]

@garronej this seems to work, by calling emotion css function twice - but it breaks the types.

[jsakas]

Actually if I change:

            getCssObjectOrCssObject:
                | ((
                      theme: Theme,
                      params: Params,
                      classes: Record<Key, string>,    // <-- here
                  ) => Record<Key, CSSObject>)
                | Record<Key, CSSObject>,

to:

            getCssObjectOrCssObject:
                | ((
                      theme: Theme,
                      params: Params,
                      classes: any,
                  ) => Record<Key, CSSObject>)
                | Record<Key, CSSObject>,

But I am not totally sure why that happens. Also any seems like not the right choice here but it does get it working.

[garronej]

Damn,
I though it was the runtime that would be hard to get working but it's actually the typings that turn out to be a problem.
I got the classes parameter to be inferred as Record<string, string> but I am still failing to to get it as Record<"el1" | "el2", string>...
Good job on the implementation though.

[garronej]

I am very disappointed 😞
I think it's a no go with the current state of typescript.
Trying to think of another API...

[jsakas]

I am very disappointed 😞
I think it's a no go with the current state of typescript.
Trying to think of another API...

Calling css function twice isn't really ideal either. I'm not sure if there is a performance hit, but it seems hacky.

I am going to run this in the meantime, until a better API emerges.

[jsakas]

@garronej also, I pushed up the change from any to Record<string, string> since it's at least a slight improvement. Even without the typings on the classes that come back in useStyles the work might still be useful to some 🤷🏻‍♂️

You might still consider a merge and then a minor version bump later in the case of a better API.

[garronej]

Hold on a minute, I want to know what you think about this

[garronej]

What do you think of that:

It's less sexy but also less voodooish and type safe...

[jsakas]

Seems fine to me if it gets the job done!

[garronej]

I test it and release it in the next hour.
Thank you very much for your involvement, it helps a lot

[garronej]

I will merge even if I override it. This way you'll appear in the contributor list.