Metadata for scenario added for json report #1368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garris
reviewed
Dec 1, 2021
There was a problem hiding this comment.
Thank you for this PR. I don't think this is something I would want to add to the code base -- but it looks very interesting-- it would probably be more useful to others as a blog post if you can show more about how you will use the metadata in your project. If you create a post I am happy to add the link to the readme doc. Cheers!
docker/Dockerfile
Outdated
| @@ -9,7 +9,7 @@ ENV \ | |||
| RUN apt-get update && \ | |||
| apt-get install -y git sudo software-properties-common | |||
|
|
|||
| RUN sudo npm install -g --unsafe-perm=true --allow-root backstopjs@${BACKSTOPJS_VERSION} | |||
| RUN sudo npm install -g --unsafe-perm=true --allow-root https://github.com/justyna-olszak-wttech/BackstopJS.git | |||
There was a problem hiding this comment.
Unfortunately we want to stay away from loading private libraries like this.
There was a problem hiding this comment.
Yes, I was pretty sure it will not meet acceptance, but this was necessary to make fork use my code within Docker build.
Therefore I'll stay with this fork trying to pass JIRA ids to XRay reporting.
justyna-olszak-wttech
force-pushed
the
master
branch
from
90c803c
to
e914db8
Compare
Details for Xray format
justyna-olszak-wttech
force-pushed
the
master
branch
2 times, most recently
from
ed86a6b
to
99ae921
Compare
justyna-olszak-wttech
force-pushed
the
master
branch
from
99ae921
to
dbf9a7a
Compare
justyna-olszak-wttech
force-pushed
the
master
branch
from
d952471
to
0649e32
Compare
justyna-olszak-wttech
force-pushed
the
master
branch
2 times, most recently
from
c811411
to
59f1cfe
Compare
justyna-olszak-wttech
force-pushed
the
master
branch
from
59f1cfe
to
14aaf23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project I use BackstopJS in required an option to pass some metadata for each scenario into the final JSON output, to be used by other monitoring tools. The solution is covered in this fork.
Such use case is for example JIRA ticket number. It allows to have additonal information next to tested pair for easier project maintenance and stories reference.
I believe it is valuable addiont, that can be used also by other teams. @garris