URL: return early in getFilename where url argument is falsy (WordPre…

…ss#60265) * Return early for falsy values so the URL constructor doesn't return `'undefined' <string>` which could be interpreted by consumers as truthy Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
garridinsi · Apr 9, 2024 · 8709d13 · 8709d13
1 parent eb435ea
commit 8709d13
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/url/src/get-filename.js b/packages/url/src/get-filename.js
@@ -13,6 +13,11 @@
  */
 export function getFilename( url ) {
 	let filename;
+
+	if ( ! url ) {
+		return;
+	}
+
 	try {
 		filename = new URL( url, 'http://example.com' ).pathname
 			.split( '/' )

diff --git a/packages/url/src/test/index.js b/packages/url/src/test/index.js
@@ -283,6 +283,8 @@ describe( 'getFilename', () => {
 		);
 		expect( getFilename( 'a/path/' ) ).toBe( undefined );
 		expect( getFilename( '/' ) ).toBe( undefined );
+		expect( getFilename( undefined ) ).toBe( undefined );
+		expect( getFilename( null ) ).toBe( undefined );
 	} );
 } );