Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various mods #29

Merged
merged 13 commits into from
May 30, 2020
Merged

Various mods #29

merged 13 commits into from
May 30, 2020

Conversation

r4dius
Copy link
Contributor

@r4dius r4dius commented Apr 27, 2020

  • Add simple version / latest version number like "(1)" after "65536"
  • Add recent list in opendirectorymenuitem dropdown with delete option
  • Fix menustrip checkbox size / display
  • Changed objectlistview position / width so that there's no border and when window is in full screen we can click the scoll bar at the extreme screen edge
  • Moved the "All columns" item in contextmenu to the "Copy" submenu

r4dius and others added 7 commits April 27, 2020 01:38
Got ExternalException on clipboard copy once, can't reproduce but it seems setDataObject will help with 10 automatic retries spaced by 100ms
- Add simple version / latest version number like "(1)" after "65536"
- Add recent list in opendirectorymenuitem dropdown with delete option
- Fix menustrip checkbox size / display
- Changed objectlistview position / width so that there's no border and when window is in full screen we can click the scoll bar at the extreme screen edge
- Moved the "All columns" item in contextmenu to the "Copy" submenu
@garoxas garoxas self-requested a review April 27, 2020 09:44
r4dius added 2 commits April 27, 2020 14:06
Less chunky
- Added file rename format customization form ("File Rename Format" in Options menu) with colorfull preview,
only using infos from 6 values actually (versions / name / ids), not sure what could be added
- AboutBox small changes to stuff placement
@r4dius
Copy link
Contributor Author

r4dius commented May 9, 2020

Hi, I added a form to allow changing file renaming template, not sure if I should cancel this pull request and redo it for all the new code ?

rename

only using 6 values form nsp files but can easily add more if necessary

Fix codacy checks
@garoxas
Copy link
Owner

garoxas commented May 10, 2020

as I will squash the commits anyway, you can redo all the code here
sorry I haven't got the chance to review your changes but I will do it once I do. thank you

Copy link
Owner

@garoxas garoxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for late review. I haven't got the chance to review all your changes (especially Main.cs) but here's few things that I'd like to address
I've also thought about RecentDirectories a while back but haven't got the chance to do it. I think it can also work for Open File and Open SD Card as well
Thank you

NX_Game_Info/Common.cs Outdated Show resolved Hide resolved
Windows/AboutBox.Designer.cs Outdated Show resolved Hide resolved
Windows/Main.Designer.cs Outdated Show resolved Hide resolved
Windows/Main.Designer.cs Outdated Show resolved Hide resolved
Windows/RenameBox.cs Outdated Show resolved Hide resolved
Windows/app.manifest Outdated Show resolved Hide resolved
r4dius and others added 2 commits May 21, 2020 21:50
@garoxas
Copy link
Owner

garoxas commented May 25, 2020

Hi, I tweaked some of your codes, mostly moving around with some initialization in the designer and rename some variables for the sake consistency and easier maintainability
However I couldn't seem to notice what actually affected by your changes in the Main.Designer.cs visually, and all I got was some visual glitch while restoring/maximizing the window, so I reverted that part

@garoxas garoxas self-requested a review May 25, 2020 12:37
@garoxas garoxas merged commit 53bda14 into garoxas:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants