Skip to content

Commit

Permalink
testsuite: use valgrind suppressions in issue test
Browse files Browse the repository at this point in the history
Problem: t4465-job-list-use-after-free.sh fails on aarch64.

==1006596== Syscall param epoll_ctl(event) points to uninitialised byte(s)
==1006596==    at 0x4BC9AC8: epoll_ctl (syscall-template.S:120)
==1006596==    by 0x48B5E9F: epoll_modify (ev_epoll.c:96)
==1006596==    by 0x48B7A4F: fd_reify (ev.c:2457)
==1006596==    by 0x48B7A4F: ev_run (ev.c:4075)
==1006596==    by 0x48B7A4F: ev_run (ev.c:4021)
==1006596==    by 0x48833CF: flux_reactor_run (reactor.c:128)
==1006596==    by 0x114833: main (broker.c:507)
==1006596==  Address 0x1ffeffee64 is on thread 1's stack
==1006596==  in frame #1, created by epoll_modify (ev_epoll.c:84)
==1006596==

We already have a matching suppression, but valgrind is being
called here without the suppressions loaded.

Add suppressions to test.
  • Loading branch information
garlick authored and mergify[bot] committed Aug 9, 2022
1 parent abce5bc commit 2ceaaf7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions t/issues/t4465-job-list-use-after-free.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ VALGRIND=`which valgrind`
if test -z "${VALGRIND}"; then
exit 0
fi
VALGRIND_SUPPRESSIONS=${SHARNESS_TEST_SRCDIR}/valgrind/valgrind.supp

STATEDIR=issue4470-statedir

Expand All @@ -24,4 +25,5 @@ flux start --test-size=1 -o,-Sstatedir=${STATEDIR} \
--wrap=--child-silent-after-fork=yes \
--wrap=--num-callers=30 \
--wrap=--error-exitcode=1 \
--wrap=--suppressions=$VALGRIND_SUPPRESSIONS \
bash -c "flux job purge --force --num-limit=4 && flux jobs -a 2>/dev/null"

0 comments on commit 2ceaaf7

Please sign in to comment.