Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker from gardener feature #2049

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Remove docker from gardener feature #2049

merged 2 commits into from
Mar 19, 2024

Conversation

fwilhe
Copy link
Member

@fwilhe fwilhe commented Mar 19, 2024

Gardener does not rely on docker anymore, so we can remove it to provide a more minimal image.

@Vincinator
Copy link
Contributor

We may want to remove this test: features/base/test/test_docker.py

@fwilhe
Copy link
Member Author

fwilhe commented Mar 19, 2024

We may want to remove this test: features/base/test/test_docker.py

Good find, thanks, I assumed all related tests were in the gardener feature folder.

Copy link
Contributor

@Vincinator Vincinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Lets merge and see if platform tests tomorrow are happy

@Vincinator Vincinator merged commit 6d08af4 into main Mar 19, 2024
125 checks passed
@Vincinator Vincinator deleted the remove-docker branch March 19, 2024 16:46
Vincinator pushed a commit that referenced this pull request Mar 21, 2024
* Remove docker from gardener feature

* Remove docker-in-gardener-specific test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants