Fix ping failure due to overflow in sequence number check #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeindel
requested review from
DockToFuture,
marwinski,
ScheererJ and
axel7born
as code owners
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
needs/review
gardener-robot-ci-1
added
needs/ok-to-test
MartinWeindel
added a commit
that referenced
this pull request
Dec 9, 2024
cherry-picking #120 ```improvement operator Fix ping failure due to 16bit overflow in sequence number check. ```
MartinWeindel
added a commit
that referenced
this pull request
Dec 9, 2024
cherry-picking #120 ```improvement operator Fix ping failure due to 16bit overflow in sequence number check. ```
|
/lgtm |
axel7born
approved these changes
Dec 9, 2024
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The vpn-path-controller performs regular pings to both vpn-shoot pods in the VPN HA setup.
The ping response are validated. Especially the ping sequence number is compared.
The sequence number is marshalled as 16-bit integer, but uses a 32-bit counter in the code.
The comparison for long running kube-apiserver pods starts to fails after about 36h, and none of the both VPN tunnels can be used anymore.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: