Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --version flag to show build info #10

Closed

Conversation

AleksandarSavchev
Copy link
Member

@AleksandarSavchev AleksandarSavchev commented Aug 3, 2022

What this PR does / why we need it:
Added flag --version which shows build info in json format:
Screenshot 2022-08-03 at 15 56 14

Which issue(s) this PR fixes:
Fixes #8

Special notes for your reviewer:
In the Dockerfile before the build command I change to the directory of main.go because VCS info is missing in BuildInfo when running go build with a specified .go file https://togithub.com/golang/go/issues/51279
Release note:

`--version ` flag that shows version information

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner August 3, 2022 13:10
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 3, 2022
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 3, 2022
@AleksandarSavchev
Copy link
Member Author

Closed for fix

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --version flag
3 participants