Fix edge-case where scale-from-zero of MCD is mistaken for a rolling update #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @thiyyakat for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
gardener-robot
added
needs/review
elankath
reviewed
Nov 22, 2024
thiyyakat
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
size/m
thiyyakat
force-pushed
the
bug/scaling-event
branch
from
41a8684 to
d9bf45a
Compare
unmarshall
reviewed
Nov 22, 2024
| @@ -674,8 +674,16 @@ func (dc *controller) isScalingEvent(ctx context.Context, d *v1alpha1.MachineDep | |||
| if err != nil { | |||
| return false, err | |||
| } | |||
| if newIS == nil { | |||
There was a problem hiding this comment.
the doc string for this method is not in sync with the implementation. Can you please update it?
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
reviewed/ok-to-test
rishabh-11
added
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
rishabh-11
added
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR adds a check to distinguish between a rolling update and a scale-from-zero scenario. Additionally, it also updates the integration tests to verify MCM's behaviour for the scenario.
Which issue(s) this PR fixes:
Fixes #952
Special notes for your reviewer:
Integration tests with mcm-provider-gcp passed successfully.
Release note: