Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Architecture in NodeTemplate #894

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Added Architecture in NodeTemplate #894

merged 3 commits into from
Jan 23, 2024

Conversation

sssash18
Copy link
Contributor

@sssash18 sssash18 commented Jan 11, 2024 •
edited
Loading

What this PR does / why we need it:
This PR adds architecture field in the node template
Which issue(s) this PR fixes:
Fixes part of #gardener/autoscaler#122

Special notes for your reviewer:

Release note:

Architecture field added in the nodetemplate. This will allow CA to pickup architecture from machine class and schedule pods on relevant arch nodes.

@sssash18 sssash18 requested a review from a team as a code owner January 11, 2024 05:40
@gardener-robot gardener-robot added the needs/review Needs review label Jan 11, 2024
@sssash18 sssash18 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 12, 2024
rishabh-11
rishabh-11 requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added architecture as a required field. Is it a required field, though? It is needed only in case of arm64 nodes, right? Can we keep it as an optional field?

@gardener-robot gardener-robot added needs/changes Needs (more) changes kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 18, 2024
@sssash18
Copy link
Contributor Author

You have added architecture as a required field. Is it a required field, though? It is needed only in case of arm64 nodes, right? Can we keep it as an optional field?

Yes could be done , because by default the node will always have amd64 as arch label. This is true in gardener scenario.
But for standalone mcm , this can lead to a case when pod with amd64 affinity might not get scheduled as the node does not have any arch field even though the node is amd64.

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 19, 2024
@unmarshall
Copy link
Contributor

Looks good. Please add a release note in the PR.

unmarshall
unmarshall reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment.

kubernetes/crds/machine.sapcloud.io_machineclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/machine/v1alpha1/machineclass_types.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 22, 2024
@unmarshall unmarshall requested a review from rishabh-11 January 22, 2024 10:23
rishabh-11
rishabh-11 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2024
@rishabh-11 rishabh-11 merged commit 357c319 into gardener:master Jan 23, 2024
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elankath elankath elankath left review comments

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@unmarshall unmarshall unmarshall approved these changes

Assignees

@unmarshall unmarshall

@sssash18 sssash18

Labels
kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sssash18 @unmarshall @elankath @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot