-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to local setup scripts and introduce new local setup scripts for non-gardener use cases #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update development/local_setup.md
if possible. Need to roll this out to new joinees. If you don't have time, I can do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also remove hack/admin-kube-config-request.json
This file gets removed when you can the gardener_restore.sh script
But i can also remove it once the kube configs have been downloaded successfully. |
I have updated the local_setup.md now. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working well for me now
Thanks for the changes @unmarshall !
/needs second-opinion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing doc. We need to clean the IT setup to avoid the symbolic link. let the path to MCM repo be given in the new .env
file. This can be taken up later, not now.
/lgtm
What this PR does / why we need it:
Creates separate local setup scripts for gardener and non-gardener use cases.
There are now 4 scripts that are made available:
For gardener specific setup/restore following scripts have been introduced:
Makefile
targets have the following changes:For non-gardener use cases the following scripts have been introduced:
Makefile
targets have the following changes:Which issue(s) this PR fixes:
Fixes Part of #846
Special notes for your reviewer:
Release note: