Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: Fix the format verb #831

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Nit: Fix the format verb #831

merged 1 commit into from
Jul 19, 2023

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:

{"log":"(SetReplicasAnnotations) ms.Name: shoot--foo--bar-default-z3-797b7 desired: 0 , max: 0 , updated: %!d(bool=true)","pid":"1","severity":"INFO","source":"deployment_util.go:615"}

The updated var is boolean, hence %t should be used instead of %d. Ref https://pkg.go.dev/fmt

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

@ialidzhikov ialidzhikov requested a review from a team as a code owner June 19, 2023 13:35
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 19, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 19, 2023
unmarshall
unmarshall approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 19, 2023
@himanshu-kun himanshu-kun merged commit dbbaa45 into gardener:master Jul 19, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ialidzhikov @unmarshall @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @himanshu-kun