Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated code-owners, contributing file #771

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Updated code-owners, contributing file #771

merged 1 commit into from
Feb 1, 2023

Conversation

himanshu-kun
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@himanshu-kun himanshu-kun requested a review from a team as a code owner January 27, 2023 11:38
@gardener-robot gardener-robot added the needs/review Needs review label Jan 27, 2023
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jan 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 27, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 27, 2023
rishabh-11
rishabh-11 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 1, 2023
@rishabh-11 rishabh-11 merged commit 60cb776 into gardener:master Feb 1, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 1, 2023
@himanshu-kun himanshu-kun added this to the v0.49 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@ashwani2k ashwani2k Awaiting requested review from ashwani2k

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot