Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satisfy linter #658

Closed
wants to merge 6 commits into from
Closed

Satisfy linter #658

wants to merge 6 commits into from

Conversation

majst01
Copy link

@majst01 majst01 commented Nov 12, 2021 •
edited
Loading

What this PR does / why we need it:

First round of fixes identified by running golangci-lint as proposed in #655

Depends on #655

Special notes for your reviewer:

Every commit is fixing one specific group of linter findings:

  • remove unused variables and funcs
  • remove unused func params
  • fix missing errcheck and potential nil pointer access
  • replace deprecated discoveryclient func

Issues in cloud provider specific code are left untouched because they are removed in #653

Release note:

fix first round of linter findings

@majst01 majst01 requested a review from a team as a code owner November 12, 2021 09:15
@gardener-robot
Copy link

@majst01 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 12, 2021
@gardener-robot-ci-3
Copy link
Contributor

Thank you @majst01 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@majst01 majst01 marked this pull request as draft November 12, 2021 09:16
@gardener-robot
Copy link

@majst01 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Mar 22, 2022
@majst01 majst01 closed this Aug 28, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 28, 2022
@majst01 majst01 deleted the satisfy-linter branch August 28, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majst01 @gardener-robot @gardener-robot-ci-3