Fixed empty machineID issue and enhanced print statements #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanth26
added
exp/beginner
hardikdr
reviewed
Mar 1, 2019
pkg/controller/machine.go
Outdated
| _, err = driver.GetMachine(machineID) | ||
| if err != nil && status.Code(err) != codes.Unimplemented { | ||
| // If GetMachine was implemented and error occurred | ||
| glog.V(2).Infof("Get Machine called failed with the following error: %s", err) |
There was a problem hiding this comment.
GetMachine call failed - typo ?
pkg/controller/machine.go
Outdated
| err = driver.ShutDownMachine(machineID) | ||
| if err != nil && status.Code(err) != codes.Unimplemented { | ||
| // If ShutDownMachine was implemented and error occurred | ||
| glog.V(2).Infof("Shutdown Machine called failed with the following error: %s", err) |
prashanth26
added a commit
that referenced
this pull request
Sep 11, 2019
ghost
added
the
component/mcm
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes issues on machine-controller-manager while integrating with
cmi-clientbranch.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: