Updated documentation to adapt to new gRPC services #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanth26
added
kind/enhancement
prashanth26
changed the title
hardikdr
approved these changes
Feb 12, 2019
docs/development/new_cp_support.md
Outdated
| ``` | ||
| 1. Navigate into the newly created repository. | ||
| 1. Navigate into the newly directory. |
docs/development/new_cp_support.md
Outdated
| 1. Fill in the methods described at `pkg/{provider-name}/machineserver.go` to manage VMs on your cloud provider. | ||
| - To test the basic working of your driver, implementing just the create & delete would suffice. | ||
| - The request and response parameters for each of the methods to be implemented are well documented as comments and sample codes at `pkg/{provider-name}/machineserver.go`. | ||
| - Once, create and delete methods behave as expected, you can fill in the rest of the methods. |
There was a problem hiding this comment.
I hoped we would have expected a user to implement GetMachine as well, seems something very basic to be implemented for features like safety-controller and in case we implement GetMachine before every CreateMachine call on mcm. Leaving the decision to you.
There was a problem hiding this comment.
I have made the suggested changes and mandated basic methods - https://github.com/gardener/machine-controller-manager/pull/221/files#diff-d01da958f03686a1e51543cad6dcd458R58
prashanth26
force-pushed
the
cmi-client
branch
from
41e64cf to
169aa2a
Compare
hardikdr
approved these changes
Feb 13, 2019
prashanth26
added a commit
that referenced
this pull request
Sep 11, 2019
* Made changes to gRPC services * Better error messages and logging * Updated provider docs to adopt documentation to new gRPC services * Updated docs * Made suggested changes in documentation
ghost
added
the
component/mcm
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updated documentation and code while adding new provider support using new gRPC services.
Which issue(s) this PR fixes:
Fixes #215
Special notes for your reviewer:
Release note:
cc: @afritzler