Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning of MCM with new MachineAPIs #230

Closed
prashanth26 opened this issue Feb 25, 2019 · 2 comments
Closed

Versioning of MCM with new MachineAPIs #230

prashanth26 opened this issue Feb 25, 2019 · 2 comments
Labels
component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) kind/api-change API change with impact on API users kind/question Question (asking for help, advice, or technical detail) lifecycle/stale Nobody worked on this for 6 months (will further age) status/new Issue is new and unprocessed topology/seed Affects Seed clusters

Comments

@prashanth26
Copy link
Contributor

prashanth26 commented Feb 25, 2019

The machine-controller-manager soon is expected to implement a newer version of MachineAPI on the closure of this issue. However, with this we need a mechanism to explicitly indicate that there is a change in API versioning and MCM support. The question here is how this can be handled? There are two aspects to consider here,

  1. MachineAPI versioning
  • Stick to v1alpha1? or move to something like v1alpha2/v1beta1?
  1. Machine-controller-manager release semantic versioning
  • Continue with 0.X.Y versioning with a new minor release or move to 1.0.0. release for the new APIs?

CC: @amshuman-kr @PadmaB @hardikdr @swapnilgm

@prashanth26 prashanth26 added kind/question Question (asking for help, advice, or technical detail) kind/api-change API change with impact on API users status/new Issue is new and unprocessed component/machine-controller-manager topology/seed Affects Seed clusters labels Feb 25, 2019
@prashanth26
Copy link
Contributor Author

prashanth26 commented Apr 26, 2019

The following steps are required to make OOT available to external parties to make use of the feature

  • Create CI script for machine-spec
  • New Release for machine-spec
  • Create CI script for MCM-AWS
  • New Release for MCM-AWS
  • Rebase MCM/cmi-client with master. Wait for taints support in master before doing this?
  • Refactor unit tests for MCM
  • Refactor integration tests for MCM
  • Refactor CI script for new MCM
  • New MCM release - Issue #230.
  • SampleProviders repo had to be updated with test overview Issue AWS#8

Points to consider for the future

  • Make use of gRPC metadata to avoid unnecessary calls.

@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 25, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 31, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 31, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) component/machine-controller-manager labels Mar 2, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 7, 2020
@prashanth26
Copy link
Contributor Author

Closing this issue in favor of - https://github.com/gardener/machine-controller-manager/releases/tag/v0.30.0. We stuck to v1alpha1 and release version to continue with minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) kind/api-change API change with impact on API users kind/question Question (asking for help, advice, or technical detail) lifecycle/stale Nobody worked on this for 6 months (will further age) status/new Issue is new and unprocessed topology/seed Affects Seed clusters
Projects
None yet
Development

No branches or pull requests

2 participants