Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with gg 1.103 with pod network being a slice #177

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix issue with gg 1.103 with pod network being a slice #177

merged 1 commit into from
Sep 16, 2024

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Sep 14, 2024 •
edited
Loading

How to categorize this PR?

/area conrol-plane
/kind bug
/platform openstack

What this PR does / why we need it:

Necessary to create machines after gardener/gardener-extension-provider-openstack#850

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow input of pod CIDRs as slice.

@kon-angelo kon-angelo requested review from a team as code owners September 14, 2024 10:44
@gardener-robot gardener-robot added needs/review Needs review kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else kind/bug Bug platform/openstack OpenStack platform/infrastructure labels Sep 14, 2024
@gardener-robot
Copy link

@kon-angelo Label area/conrol-plane does not exist.

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Sep 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 14, 2024
@gardener-robot
Copy link

@kon-angelo Label area/conrol-plane does not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2024
hebelsan
hebelsan previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 16, 2024
@gardener-robot gardener-robot added needs/review Needs review needs/second-opinion Needs second review by someone else and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Sep 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 16, 2024
@kon-angelo kon-angelo mentioned this pull request Sep 16, 2024
Merged
@kon-angelo kon-angelo merged commit f4d9ee3 into gardener:master Sep 16, 2024
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 16, 2024
@kon-angelo kon-angelo deleted the 103fix branch September 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ left review comments

@AndreasBurger AndreasBurger AndreasBurger approved these changes

@hebelsan hebelsan hebelsan left review comments

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kon-angelo @gardener-robot @AndreasBurger @hebelsan @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3