Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes docker image #148

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fixes docker image #148

merged 3 commits into from
Jun 28, 2024

Conversation

sssash18
Copy link
Contributor

@sssash18 sssash18 commented Jun 28, 2024 •
edited
Loading

How to categorize this PR?
This PR provides a flag to specify target platform for the docker image

/area dev-productivity
/platform openstack

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #gardener/machine-controller-manager#921

Special notes for your reviewer:

Release note:

@sssash18 sssash18 requested review from a team as code owners June 28, 2024 05:46
@gardener-robot gardener-robot added needs/review Needs review platform/aws Amazon web services platform/infrastructure labels Jun 28, 2024
@gardener-robot
Copy link

@sssash18 Labels area/todo, kind/todo do not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jun 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 28, 2024
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) platform/openstack OpenStack platform/infrastructure labels Jun 28, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2024
@sssash18 sssash18 mentioned this pull request Jun 28, 2024
Closed
6 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2024
aaronfern
aaronfern approved these changes Jun 28, 2024
View reviewed changes
Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 28, 2024
@aaronfern aaronfern merged commit 8366a14 into gardener:master Jun 28, 2024
6 checks passed
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 28, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sssash18 @gardener-robot @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3