Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update aks deployment document #606

Merged
merged 1 commit into from
Dec 16, 2018
Merged

update aks deployment document #606

merged 1 commit into from
Dec 16, 2018

Conversation

bergerx
Copy link
Contributor

@bergerx bergerx commented Dec 15, 2018

What this PR does / why we need it:
AKS deployment guide was old.

Which issue(s) this PR fixes:
Fixes #551

Special notes for your reviewer:

  • Replaced all static manifests with either upstream links or imperative object creation commands, so I removed them all. But depends on Add helm chart etcd-backup-restore#59 to be merged, I used the etcd-backup-restore chart instead of the static etcd manifests.
  • Given the development speed of the gardener project, this document got obsolete in months and same will likely happen quite fast again. Hoping there will be less changes in gardener helm chart structure, I removed the pinned Gardener version from the values file and started using chained helm values files for gardener chart (-f charts/gardener/local-values.yaml -f gardener-values.yaml). Overriding only the required fields over the local development values file to keep the delta as small as possible.
  • Also, depends on example project now uses fixed namespace #605 to be merged, since I'm using the example/05-project-dev.yaml file as is.

Release note:

NONE

@bergerx bergerx requested a review from a team as a code owner December 15, 2018 02:24
@rfranzke rfranzke added kind/enhancement Enhancement, improvement, extension reviewed/ok-to-test area/documentation Documentation related size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2018
rfranzke
rfranzke approved these changes Dec 16, 2018
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thank you!

@rfranzke rfranzke merged commit c151ab7 into gardener:master Dec 16, 2018
@bergerx bergerx mentioned this pull request Jan 16, 2019
Closed
@ghost ghost added the platform/azure Microsoft Azure platform/infrastructure label Mar 7, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
ialidzhikov pushed a commit to ialidzhikov/gardener that referenced this pull request Aug 1, 2024
@petersutter @grolu
Bug fixes for Clusterlist journal columns (gardener#606)
21d713d 
* fixed not defined property

* Fixed: Journal Columns visible for non admins

* fixed fix

Co-authored-by: Lukas Gross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/documentation Documentation related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the AKS deployment guide
4 participants
@bergerx @rfranzke @gardener-robot-ci-1 @gardener-robot