[GEP-7] Adds check for seed provider type when changing the seed name of shoot #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane-migration
vpnachev
reviewed
Dec 2, 2020
There was a problem hiding this comment.
Just a minor suggestion for the name of the old seed to make it more clear. It is strange to me that the old seed is named "new..."
Also, names cannot contain brackets, ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names.
| @@ -1951,6 +1953,27 @@ var _ = Describe("validator", func() { | |||
|
|
|||
| Expect(err).To(HaveOccurred()) | |||
| }) | |||
|
|
|||
| It("should fail to change Seed name, because cloud provider for new Seed is not equal to cloud provider for old Seed", func() { | |||
| oldSeedName := fmt.Sprintf("new(%s)", seedName) | |||
There was a problem hiding this comment.
Suggested change
| oldSeedName := fmt.Sprintf("new(%s)", seedName) | |
| oldSeedName := fmt.Sprintf("old-%s", seedName) |
There was a problem hiding this comment.
ops forgot to change this after I modified the variable name.
plkokanov
force-pushed
the
cp-migration/check-provider
branch
from
ef17421 to
ec5794c
Compare
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane-migration
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR forbids changing the
Shoot.Spec.SeedNamefield of aShootcluster if the newSeedhas different cloud provider from the old one. Currently control planes cannot be migrated betweenSeedswith different providers, although we could implement this in the future.Which issue(s) this PR fixes:
Part of #1631
Special notes for your reviewer:
Release note: