Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds skaffold based setup #5

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Adds skaffold based setup #5

merged 1 commit into from
Aug 25, 2023

Conversation

plkokanov
Copy link
Collaborator

@plkokanov plkokanov commented Aug 25, 2023

/kind enhancement

What this PR does / why we need it:
Adds skaffold based setup for local development and removes the no longer necessary rsyslog-relp-up-kind.sh script.

Additionally, the image field for the extension's ControllerRegistration is now flattened in the form of image: repository:tag so that it can be modified by skaffold with the following config:

resourceSelector:
  allow:
  # instruct skaffold to inject the built image reference into the image field in our ControllerDeployment
  - groupKind: ControllerDeployment.core.gardener.cloud
    image: [".*"]

This appropriate change is also done in the charts for the extension so that the ControllerRegistration is generated properly.

Finally, some no longer necessary values have been removed from the charts.

Which issue(s) this PR fixes:
Part of #2

Special notes for your reviewer:

Release note:

Added `skaffold` based setup for local development. The extension can now be deployed in a local gardener kind cluster with the `make extension-up` or `make extension-dev` commands. The extension can be deleted by executing `make extension-down`.
The image field in the `ControllerRegistration` of the extension and in the `gardener-extension-shoot-rsyslog-relp` charts has been flattened so that it is in the form `image: repository:tag`.

@gardener-robot gardener-robot added needs/review size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2023
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Aug 25, 2023
@plkokanov plkokanov merged commit e0b3059 into main Aug 25, 2023
@plkokanov plkokanov deleted the add-skaffold-setup branch August 25, 2023 13:07
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this pull request Sep 4, 2023
The change incorporates the changes from gardener/gardener#7757 and gardener/gardener-extension-shoot-rsyslog-relp#5.

It simplifies the skaffold setup and drops the ControllerRegistration chart (`./charts/registration`). The `make extension-up` target is now fixed and invoked by the `make ci-e2e-kind` target now.
gardener-prow bot pushed a commit to gardener/gardener-extension-registry-cache that referenced this pull request Sep 11, 2023
#40)

* This PR improves the skaffold setup of the extension

The change incorporates the changes from gardener/gardener#7757 and gardener/gardener-extension-shoot-rsyslog-relp#5.

It simplifies the skaffold setup and drops the ControllerRegistration chart (`./charts/registration`). The `make extension-up` target is now fixed and invoked by the `make ci-e2e-kind` target now.

* Add docs

* Drop the `make start`, `make start-admission` and `make debug-admission` targets

Dropping these targets makes sense because:
- similar to gardener we have skaffold setup and gardener dropped `make start-*` targets
- some of these targets were already outdated, hence, it means that they are not used
- the setup required for these targets is not easy (compared to the skaffold setup), or at least not documented

We already have the skaffold-based local setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants