Publish Helm charts as OCI artifacts #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
oliver-goetz
changed the title
51 tasks
vpnachev
requested changes
Jul 29, 2024
.gitignore
Outdated
| @@ -20,6 +20,5 @@ testbin | |||
| *~ | |||
| dive.log | |||
| /tmp | |||
| /example/lakom | |||
There was a problem hiding this comment.
Why is this dir no longer ignored? There are several generated files (TLS certs, cosign keys, etc.) that are stored there and they should not be tracked by the VSC. You can generate these files with make dev-setup.
There was a problem hiding this comment.
I did not notice that it is used by make dev-setup too and reverted the change.
… helm chart according to common structure used for extensions
oliver-goetz
force-pushed
the
enh/publish-helm-charts
branch
from
e725ef2 to
be96d1b
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
status/closed
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area delivery
/kind enhancement
What this PR does / why we need it:
We should start publishing Helm charts as OCI artifacts that we can deploy them as
Extensionin the future (see gardener/gardener#9635).I had to adapt the specification of
imageingardener-extension-shoot-lakom-serviceHelm chart that the pipeline is able to overwrite the values correctly.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: