-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lakom uses warning instead of failure policy Ignore
#74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong opinion, so I am fine both ways.
As a general comment I think that "skip" is not the proper term to use here since we still do the validation, but allow the image even if validation fails. So IMO "allow" should be the better term.
A second note. What is the use case for this change and why is it better than the ability to ignore denied requests as it is now?
The failure policy in kubernetes is scoped only to completing the admission review process, not the result of the admission review, i.e. whether the change is allowed or not. Failure policy Lakom is deployed HA and by default runs locally to the cluster (in-cluster for the seeds and in the control plane for the shoots), so we should not have any expectation that the admission reviewes are subject to failure because of unreliable network, unavailable lakom instances, etc. Failure policy There are several benefits from this change:
|
e3740d9
to
15eb9f6
Compare
New flag `--insecure-allow-untrusted-images` allows lakom to run in detective mode, it will not disallow unsigned images, it will just return warnings.
Extension controller config is extended with `allowUntrustedImages` field which is set as value of the flag `insecure-allow-untrusted-images`.
Now when failure policy is always Fail, there is no need of custom admission handler to set the HTTP status code to be the same as the admission review status code.
It is no longer possible to control the failure policy of the admission webhook configurations. If unsigned images must be allowed, `allowUntrustedImages=true` can be used.
15eb9f6
to
c009d67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions that are completely optional
/lgtm
Co-authored-by: Dimitar Mirchev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Lakom uses warning instead of failure policy
Ignore
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: