Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linter for ./test/... and fix findings #70

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Enable linter for ./test/... and fix findings #70

merged 1 commit into from
Feb 21, 2024

Conversation

vpnachev
Copy link
Member

What this PR does / why we need it:
Enable linter for ./test/... and fix findings

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@vpnachev vpnachev requested a review from a team as a code owner February 20, 2024 19:02
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 20, 2024
@vpnachev vpnachev mentioned this pull request Feb 20, 2024
Merged
dimityrmirchev
dimityrmirchev approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/system/lifecycle/lifecycle_test.go Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
@vpnachev vpnachev merged commit 4144416 into gardener:main Feb 21, 2024
8 checks passed
@vpnachev vpnachev deleted the fix/typos-in-test branch February 21, 2024 07:39
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vpnachev @dimityrmirchev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot