Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sigstore dependencies #6

Merged
merged 6 commits into from
May 11, 2023
Merged

Update sigstore dependencies #6

merged 6 commits into from
May 11, 2023

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented May 9, 2023 •
edited
Loading

What this PR does / why we need it:
Update sigstore dependencies

Which issue(s) this PR fixes:
Supersede #1 and #2.
Close #1
Close #2

Special notes for your reviewer:

Release note:

The following dependencies are updated:
- github.com/prometheus/client_golang: v1.14.0 -> v1.15.0
- github.com/sigstore/cosign: v1.13.1 -> v2.0.2
- github.com/sigstore/sigstore: v1.4.5 -> v1.6.3
- golang.org/x/tools: v.0.4.0 -> v0.8.0
- github.com/docker/docker v20.10.20+incompatible -> v23.0.3+incompatible

@vpnachev vpnachev requested a review from a team as a code owner May 9, 2023 14:11
@gardener-robot gardener-robot added the needs/review Needs review label May 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 9, 2023
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 9, 2023
@vpnachev vpnachev requested a review from dimityrmirchev May 10, 2023 11:30
dimityrmirchev
dimityrmirchev requested changes May 10, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and a couple of questions. Other looks good

pkg/lakom/verifysignature/verifier.go Outdated Show resolved Hide resolved
pkg/lakom/verifysignature/verifier.go Outdated Show resolved Hide resolved
pkg/lakom/verifysignature/verifier.go Show resolved Hide resolved
pkg/lakom/verifysignature/verifier.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 10, 2023
vpnachev and others added 2 commits May 10, 2023 17:39
@vpnachev @dimityrmirchev
Fix typo
740a27f 
Co-authored-by: Dimitar Mirchev <[email protected]>
@vpnachev @dimityrmirchev
Fix typo
390acb8 
Co-authored-by: Dimitar Mirchev <[email protected]>
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2023
@vpnachev vpnachev requested a review from dimityrmirchev May 10, 2023 15:36
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2023
dimityrmirchev
dimityrmirchev approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels May 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2023
@vpnachev vpnachev merged commit 02c395c into gardener:main May 11, 2023
@vpnachev vpnachev deleted the update-sigstore-dependencies branch May 11, 2023 06:25
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpnachev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot