Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extension controller chart to read correctly controllers.useOnlyImagePullSecrets #51

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix extension controller chart to read correctly controllers.useOnlyImagePullSecrets #51

merged 1 commit into from
Nov 9, 2023

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Nov 9, 2023

What this PR does / why we need it:
Fix extension controller chart to read correctly controllers.useOnlyImagePullSecrets

Which issue(s) this PR fixes:
Follow up on #49

Special notes for your reviewer:

Release note:

@vpnachev vpnachev requested a review from a team as a code owner November 9, 2023 10:44
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 9, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 9, 2023
dimityrmirchev
dimityrmirchev approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2023
@vpnachev vpnachev merged commit afa128e into gardener:main Nov 9, 2023
1 check passed
@vpnachev vpnachev deleted the fix/extension-controller-chart branch November 9, 2023 12:08
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpnachev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot