Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix immutable RoleBinding.roleRef #115

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix immutable RoleBinding.roleRef #115

merged 1 commit into from
Oct 22, 2024

Conversation

vpnachev
Copy link
Member

What this PR does / why we need it:
Fix immutable RoleBinding.roleRef

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A bug in the lakom extension controller trying to update the immutable `roleRef` field in the `(Cluster)RoleBinding` resource without recreating it has been fixed.

@vpnachev vpnachev requested a review from a team as a code owner October 22, 2024 07:53
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 22, 2024
rrhubenov
rrhubenov approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@rrhubenov rrhubenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rickardsjp
rickardsjp approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@rickardsjp rickardsjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 22, 2024
@vpnachev vpnachev merged commit d861483 into gardener:main Oct 22, 2024
12 checks passed
@vpnachev vpnachev deleted the fix/immutable-rolebinding-roleref branch October 22, 2024 08:04
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 22, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrhubenov rrhubenov rrhubenov approved these changes

@rickardsjp rickardsjp rickardsjp approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpnachev @rickardsjp @rrhubenov @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot