Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.22.5 #101

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Update go to 1.22.5 #101

merged 1 commit into from
Jul 31, 2024

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Jul 30, 2024 •
edited
Loading

What this PR does / why we need it:
Update go to 1.22.5

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Lakom application and lakom extension controller are now build with Go version 1.22.5

@vpnachev vpnachev requested a review from a team as a code owner July 30, 2024 15:00
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 30, 2024
@vpnachev vpnachev mentioned this pull request Jul 31, 2024
Closed
@rrhubenov
Copy link
Contributor

rrhubenov commented Jul 31, 2024 •
edited
Loading

Should the go version be changed in go.mod as well?

@rrhubenov
Copy link
Contributor

Should the go version be changed in go.mod as well?

Ah, just found out that's the minimum required go version, so it should be fine

@rrhubenov
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 31, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 31, 2024
@vpnachev vpnachev merged commit 5df5d8b into gardener:main Jul 31, 2024
9 checks passed
@vpnachev vpnachev deleted the update-golang branch July 31, 2024 13:59
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrhubenov rrhubenov rrhubenov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vpnachev @rrhubenov @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot