Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional provider PowerDNS #374

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Additional provider PowerDNS #374

merged 2 commits into from
Oct 8, 2024

Conversation

simcod
Copy link
Contributor

@simcod simcod commented Sep 3, 2024

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Adds PowerDNS as additional provider.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Related to

Release note:

Adds PowerDNS as additional provider

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension labels Sep 3, 2024
@gardener-robot
Copy link

@simcod Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 3, 2024
@gardener-robot-ci-3
Copy link
Contributor

Thank you @simcod for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@MartinWeindel
Copy link
Member

related to gardener/external-dns-management#390

@simcod simcod marked this pull request as ready for review September 11, 2024 07:00
@simcod simcod requested review from a team as code owners September 11, 2024 07:00
MartinWeindel
MartinWeindel approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 8, 2024
@MartinWeindel MartinWeindel merged commit 5805706 into gardener:master Oct 8, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 8, 2024
@simcod simcod deleted the additional-provider-powerdns branch October 23, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simcod @CLAassistant @gardener-robot @gardener-robot-ci-3 @MartinWeindel @gardener-robot-ci-1