Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the component unit tests to use the managedResourceObjectsMatcher #302

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Dec 10, 2024

How to categorize this PR?

/area testing
/area dev-productivity
/kind enhancement

What this PR does / why we need it:
The managedResourceObjectsMatcher is introduced with gardener/gardener#9964 in gardener/[email protected]. We had an item in our backlog to evaluate it and potentially start using it.
The managedResourceObjectsMatcher:

  • reduces some boilerplate - we no longer need to fetch the ManagedResource Secret, then uncompress and decode it to fetch the manifest inside
  • we can pass native go types for the expected resources instead of serialized YAML manifests. The YAML manifests are sensitive to whitespace and key order.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added area/testing Testing related area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension labels Dec 10, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 10, 2024
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
Copy link
Contributor

gardener-prow bot commented Dec 10, 2024

LGTM label has been added.

Git tree hash: d72acde0e2082c3017769d4b1c46e34fad246476

Copy link
Contributor

gardener-prow bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@gardener-prow gardener-prow bot merged commit 52e5997 into gardener:main Dec 10, 2024
6 checks passed
@ialidzhikov ialidzhikov deleted the enh/unit-test branch December 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants