Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CA rotation TM test #285

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Add CA rotation TM test #285

merged 4 commits into from
Dec 17, 2024

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented Nov 12, 2024 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area testing
/kind test

What this PR does / why we need it:
Add certificate rotation Test Machinery test to verify that registry cache is working after the Prepared and Completed rotation phases.

Which issue(s) this PR fixes:
Part of #203

Special notes for your reviewer:
The PR will be draft until #245 is merged.

Release note:

A new TM test that verifies that registry cache is working after CA rotation is introduced.

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Testing related kind/test Test do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov November 12, 2024 14:17
@dimitar-kostadinov dimitar-kostadinov mentioned this pull request Nov 12, 2024
Closed
2 tasks
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2024
@dimitar-kostadinov
Copy link
Contributor Author

/remove-lifecycle stale

@gardener-prow gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2024
@dimitar-kostadinov dimitar-kostadinov force-pushed the ehn/add_cert_rotation_tm_test branch from 62fe396 to 0770416 Compare December 13, 2024 07:30
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2024
@dimitar-kostadinov dimitar-kostadinov marked this pull request as ready for review December 13, 2024 07:31
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@dimitar-kostadinov dimitar-kostadinov force-pushed the ehn/add_cert_rotation_tm_test branch from 0770416 to 25cead1 Compare December 13, 2024 07:48
@ialidzhikov
Copy link
Member

/assign

ialidzhikov
ialidzhikov requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I will open an issue to research for options how to deal with the local-path-provisioner limitation that it cannot move PVC between Nodes.
One option that comes to my mind is to make use of in-place rolling updates when the feature is available from Gardener side. We keep adding TM tests because of this local-path-provisioner limitation while these tests can be e2e tests and be executed on PR-level.

test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
.test-defs/TestSuiteRegistryCacheDisruptiveSerial.yaml Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
test/testmachinery/shoot/enable_rotate_certs_disable_test.go Outdated Show resolved Hide resolved
@ialidzhikov
Copy link
Member

I will open an issue to research for options how to deal with the local-path-provisioner limitation that it cannot move PVC between Nodes.

Ref #307

ialidzhikov
ialidzhikov approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
until we clarify internally whether we can make the test serial

@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 16, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 16, 2024

LGTM label has been added.

Git tree hash: 965c69d4f007311f88c728aefe0c76db8da16aa8

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov December 17, 2024 11:37
ialidzhikov
ialidzhikov approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 17, 2024

LGTM label has been added.

Git tree hash: 8fe3176abe1115909cd973eeb4e3c010de4f864b

@ialidzhikov
Copy link
Member

/hold cancel

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@gardener-prow gardener-prow bot merged commit 0e6823b into gardener:main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees

@ialidzhikov ialidzhikov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/test Test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimitar-kostadinov @gardener-ci-robot @ialidzhikov