-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
skaffold: Rebuild when there are changes to
go:embed files (#57)
* skaffold: Rebuild when there are changes to `go:embed` files Currently, the ko builder does not detect changes to `go:embed` files (see GoogleContainerTools/skaffold#7836). This makes impossible the development of some scripts that are used later by `go:embed`. This PR inspires from gardener/gardener#6735 and gardener/gardener#6781 and does the same setup for the registry-cache extension. * Add skaffold dependency --------- Co-authored-by: Dimitar Kostadinov <[email protected]>
- Loading branch information
1 parent
c7ba18f
commit 31cdc3c
Showing
3 changed files
with
113 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| #!/usr/bin/env bash | ||
| # | ||
| # Copyright 2022 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -e | ||
|
|
||
| echo "> Check Skaffold Dependencies" | ||
|
|
||
| check_successful=true | ||
|
|
||
| out_dir=$(mktemp -d) | ||
| function cleanup_output { | ||
| rm -rf "$out_dir" | ||
| } | ||
| trap cleanup_output EXIT | ||
|
|
||
| function check() { | ||
| skaffold_file="$1" | ||
| binary_name="$2" | ||
| skaffold_config_name="$3" | ||
|
|
||
| skaffold_yaml="$(cat "$(dirname "$0")/../$skaffold_file")" | ||
|
|
||
| path_current_skaffold_dependencies="${out_dir}/current-$skaffold_file-deps-$binary_name.txt" | ||
| path_actual_dependencies="${out_dir}/actual-$skaffold_file-deps-$binary_name.txt" | ||
|
|
||
| echo "$skaffold_yaml" |\ | ||
| yq eval "select(.metadata.name == \"$skaffold_config_name\") | .build.artifacts[] | select(.ko.main == \"./cmd/$binary_name\") | .ko.dependencies.paths[]?" - |\ | ||
| sort |\ | ||
| uniq > "$path_current_skaffold_dependencies" | ||
|
|
||
| go list -f '{{ join .Deps "\n" }}' "./cmd/$binary_name" |\ | ||
| grep "github.com/gardener/gardener-extension-registry-cache/" |\ | ||
| sed 's/github\.com\/gardener\/gardener-extension-registry-cache\///g' |\ | ||
| sort |\ | ||
| uniq > "$path_actual_dependencies" | ||
|
|
||
| # always add vendor directory and VERSION file | ||
| echo "vendor" >> "$path_actual_dependencies" | ||
| echo "VERSION" >> "$path_actual_dependencies" | ||
|
|
||
| # sort dependencies | ||
| sort -o $path_current_skaffold_dependencies{,} | ||
| sort -o $path_actual_dependencies{,} | ||
|
|
||
| echo -n ">> Checking defined dependencies in Skaffold config '$skaffold_config_name' for '$binary_name' in '$skaffold_file'..." | ||
| if ! diff="$(diff "$path_current_skaffold_dependencies" "$path_actual_dependencies")"; then | ||
| check_successful=false | ||
|
|
||
| echo | ||
| echo ">>> The following actual dependencies are missing in $skaffold_file (need to be added):" | ||
| echo "$diff" | grep '>' | awk '{print $2}' | ||
| echo | ||
| echo ">>> The following dependencies defined in $skaffold_file are not needed actually (need to be removed):" | ||
| echo "$diff" | grep '<' | awk '{print $2}' | ||
| echo | ||
| else | ||
| echo " success." | ||
| fi | ||
| } | ||
|
|
||
| check "skaffold.yaml" "gardener-extension-registry-cache" "extension" | ||
| check "skaffold.yaml" "gardener-extension-registry-cache-admission" "admission" | ||
|
|
||
| if [ "$check_successful" = false ] ; then | ||
| exit 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters