Introduce Azure Accelerated Networking #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
dkistner
force-pushed
the
acc-networking
branch
from
034a710 to
c7db6cb
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
dkistner
force-pushed
the
acc-networking
branch
from
c7db6cb to
34fdbf0
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
rfranzke
requested changes
Apr 14, 2020
dkistner
force-pushed
the
acc-networking
branch
from
34fdbf0 to
cc5b2f2
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
Updated the PR. The requested test is missing. Need some more time to restructure the tests.. |
rfranzke
requested changes
Apr 17, 2020
dkistner
force-pushed
the
acc-networking
branch
from
cc5b2f2 to
baa5db0
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
Thanks @rfranzke for the review. |
dkistner
force-pushed
the
acc-networking
branch
from
baa5db0 to
554083b
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
rfranzke
reviewed
Apr 20, 2020
for machine type/os image combinations which support it.
dkistner
force-pushed
the
acc-networking
branch
from
554083b to
0ab8ffc
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
rfranzke
approved these changes
Apr 21, 2020
|
@dkistner I want to merge, but it tells
without showing them. Can you check? Maybe it's related to the GitHub issues yesterday evening, can you force-push? |
rfranzke
added a commit
to rfranzke/gardener-extension-provider-azure
that referenced
this pull request
Apr 22, 2020
Introduce Azure Accelerated Networking
|
OK, it seems that this PR was already merged and pushed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable automatically Azure Accelerated Networking for all compatible machines configurations. The machine type and os image version need to be compatible to make use of Azure Accelerated Networking.
Azure Accelerated Networking provide better networking performance, see here.
A list of compatible machine types can be maintained in the CloudProfile via
.spec.providerConfig.acceleratedNetworingMachineTypes[].The os image versions which are compatible can be maintained in the CloudProfile via
.spec.providerConfig.machineImages[].versions[].acceleratedNetworking.ℹ️ This PR require a mcm release which include gardener/machine-controller-manager#438. This is already integrated with #60.
Which issue(s) this PR fixes:
Fixes #55
Special notes for your reviewer:
Create a cluster with compatible machine type and os image version. Ssh to machine and exec instructions here.
Release note: