Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci:component:github.com/gardener/machine-controller-manager:v0.34.2->v0.34.3] #178

Merged
merged 1 commit into from
Oct 15, 2020
Merged

[ci:component:github.com/gardener/machine-controller-manager:v0.34.2->v0.34.3] #178

merged 1 commit into from
Oct 15, 2020

Conversation

gardener-robot-ci-1
Copy link
Contributor

Release Notes:

Added a more comprehensive set of events to trigger machine class reconciliations.

Finalizers are added by default for all machine class objects.

@gardener-robot-ci-1 gardener-robot-ci-1 requested review from a team as code owners October 15, 2020 07:30
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 15, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2020
prashanth26
prashanth26 approved these changes Oct 15, 2020
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 15, 2020
@dkistner dkistner merged commit b531e5b into master Oct 15, 2020
@dkistner dkistner deleted the ci-zpoqyozpb branch October 15, 2020 09:12
@rfranzke rfranzke mentioned this pull request Jul 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gardener-robot-ci-1 @dkistner @prashanth26 @gardener-robot @gardener-robot-ci-2