Prepare upgrade to Terraform azurerm v2.x.x #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add association resources for routetable-to-subnet and nsg-to-subnet in parallel to internal associations on the subnet resource.
gardener-robot
added
kind/impediment
gardener-robot-ci-2
added
reviewed/ok-to-test
|
Is this PR dependent to the azurerm version bump in terraformer? In the past we had issue with gardener-attic/gardener-extensions#331 which was reverted in gardener-attic/gardener-extensions#348. Is this now fixed? |
|
It is only fixed if you keep the inline and external association in parallel. This PR is not related to a bump of Terraform version. It is just a preparation that we can move to azurerm v2 in the future (which we need to proceed with the Nat Gateway story). |
|
/lgtm |
dkistner
added a commit
to dkistner/gardener-extension-provider-azure
that referenced
this pull request
Nov 16, 2020
Add migration to Terraform azurerm provider v2. Add migration for Gardener managed NatGateway public ip. TODO: This require gardener#161
dkistner
added a commit
to dkistner/gardener-extension-provider-azure
that referenced
this pull request
Nov 16, 2020
Add migration to Terraform azurerm provider v2. Add migration for Gardener managed NatGateway public ip. TODO: This require gardener#161
dkistner
added a commit
to dkistner/gardener-extension-provider-azure
that referenced
this pull request
Nov 16, 2020
Add migration to Terraform azurerm provider v2. Add migration for Gardener managed NatGateway public ip. TODO: This require gardener#161
gardener-robot
added
the
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add association resources for
routetable-to-subnetandnsg-to-subnetin parallel to internal associations on the subnet resource.How to categorize this PR?
/kind impediment
/priority normal
/platform azure
What this PR does / why we need it:
We need to upgrade the
azurermTerraform provider to at least version v2.12.0 as this is required for the NatGateway bring your own IP scenario (#54 (comment), hashicorp/terraform-provider-azurerm#6450, hashicorp/terraform-provider-azurerm#6052).As preparation for the upgrade we need to add the
routetable-to-subnetandnsg-to-subnetexternal association resources in parallel to the internal associations on the subnet resource. Otherwise we won't be able to upgrade toazurermv2, see here:hashicorp/terraform-provider-azurerm#2358 (comment)
Special notes for your reviewer:
Create a
Infrastructurewithout this change. Then checkout this PR and reconcile theInfrastructureonce more. The route table/nsg to subnet association on Azure should not change.Release note: