Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Subresource to mutate NamespacedCloudProfile status #1039

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Use Subresource to mutate NamespacedCloudProfile status #1039

merged 1 commit into from
Dec 16, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area usability
/kind bug
/platform azure

What this PR does / why we need it:
With gardener/gardener#10937 the mutator was not able to update the status anymore. Now, the subresource handler is properly used.

Which issue(s) this PR fixes:
Related to gardener/gardener#9504.

Special notes for your reviewer:

Release note:

Fix the `NamespacedCloudProfile` status mutation.

@LucaBernstein LucaBernstein requested review from a team as code owners December 13, 2024 14:56
@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure labels Dec 13, 2024
@LucaBernstein LucaBernstein mentioned this pull request Dec 13, 2024
Open
46 tasks
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@LucaBernstein
Copy link
Member Author

/cc @timuthy @dguendisch

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
timuthy
timuthy approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2024
hebelsan
hebelsan approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hebelsan hebelsan merged commit 28c9776 into gardener:master Dec 16, 2024
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 16, 2024
@LucaBernstein LucaBernstein deleted the fix-nscpfl-status-patching branch December 16, 2024 08:28
@LucaBernstein LucaBernstein mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LucaBernstein @hebelsan @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot