Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow reconcile ensure public ip #1035

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area usability
/kind bug
/platform azure

What this PR does / why we need it:
If a public IP was created by the azure CCM (Cloud Controller Manager) in the past with a pretty old CCM version it was tagged under the key "service" and not "k8s-azure-service".
The flow code up until now does not support this old key and therefore the reconciliation fails.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support legacy CCM service tag key in flow reconciliation

@hebelsan hebelsan requested review from a team as code owners December 10, 2024 10:27
@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 10, 2024
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebelsan hebelsan merged commit 4a50b69 into gardener:master Dec 10, 2024
15 of 16 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 10, 2024
@hebelsan hebelsan deleted the fix/ensure-ip branch December 10, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants