Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use UDP for upstream DNS by default #1032

Merged

Conversation

domdom82
Copy link
Contributor

@domdom82 domdom82 commented Dec 5, 2024

How to categorize this PR?

/area networking
/kind enhancement
/platform azure

What this PR does / why we need it:

In the past there have been issues with using TCP for upstream DNS requests on Azure. The infrastructure does not handle lots of TCP connections for DNS queries well and the cluster may run into rate throttling leading to "connection timeout" issues during DNS resolution.

To avoid users having to manually set the spec.SystemComponents.NodeLocalDNS.ForceTCPToUpstreamDNS property for Azure, this PR sets a default value (false) if the property is not set on the shoot. This will make the shoot use UDP for upstream DNS by default and should prevent the issue from the start.

Release note:

Shoots with NodeLocalDNS enabled will use UDP instead of TCP for upstream DNS queries by default to avoid performance issues on Azure.

@domdom82 domdom82 requested review from a team as code owners December 5, 2024 13:24
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 5, 2024
@domdom82 domdom82 force-pushed the fix-node-local-dns-upstream-tcp branch from 7e13f9e to 4ea6786 Compare December 5, 2024 13:50
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 5, 2024
@AndreasBurger AndreasBurger merged commit 9fbf9ae into gardener:master Dec 12, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants