Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate NamespacedCloudProfile MachineImage architectures against providerConfig #1021

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Validate NamespacedCloudProfile MachineImage architectures against providerConfig #1021

merged 1 commit into from
Dec 10, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area usability
/kind enhancement
/platform azure

What this PR does / why we need it:
Validate machine image version architectures in machine images spec and provider config.

Which issue(s) this PR fixes:

Special notes for your reviewer:
/cc @hebelsan

Release note:

@LucaBernstein LucaBernstein requested review from a team as code owners November 25, 2024 18:07
@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2024
@LucaBernstein LucaBernstein mentioned this pull request Nov 25, 2024
Open
46 tasks
@hebelsan hebelsan mentioned this pull request Nov 26, 2024
Closed
@hebelsan
Copy link
Contributor

/hold until cloudProfile generation is fixed in lss

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 26, 2024
@hebelsan
Copy link
Contributor

/unhold fix in LSS got merged

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 29, 2024
hebelsan
hebelsan approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2024
@LucaBernstein LucaBernstein merged commit 3c14bf4 into gardener:master Dec 10, 2024
21 checks passed
@LucaBernstein LucaBernstein deleted the fix-nscpfl-validation-architectures branch December 10, 2024 10:03
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaBernstein @hebelsan @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot