Respect cloud configuration in dnsrecord #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
|
/test |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
Testrun: e2e-l4c7l +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 28m12s | | infrastructure-test | infra-flow-test | Succeeded | 26m14s | | infrastructure-test | infra-flow-migration-test | Succeeded | 31m14s | | bastion-test | bastion-test | Succeeded | 9m49s | +---------------------+---------------------------+-----------+----------+ |
gardener-robot-ci-2
added
needs/ok-to-test
AndreasBurger
approved these changes
Nov 20, 2024
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind technical-debt
/platform azure
What this PR does / why we need it:
Deprecate DNSRecordConfig. Gardener (and gardenlet at the moment) has no way to pass providerConfig for DNSRecords. The cloud configuration now is coming from the secret similar to how https://github.com/gardener/external-dns-management/tree/master/docs/azure-dns#using-the-service-principal-account mentions.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: