Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NamespacedCloudProfile validation and mutation webhooks #1016

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add NamespacedCloudProfile validation and mutation webhooks #1016

merged 1 commit into from
Nov 20, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area usability
/kind enhancement
/platform azure

What this PR does / why we need it:
Support custom machine images and versions in NamespacedCloudProfiles. For that, add mutating and validating admission webhooks.

Which issue(s) this PR fixes:
Part of gardener/gardener#9504, followup to gardener/gardener#10629.

Special notes for your reviewer:
/cc @timuthy

Release note:

Add `NamespacedCloudProfile` admission mutation and validation to support custom machine images and types.

@LucaBernstein LucaBernstein requested review from a team as code owners November 18, 2024 15:14
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 18, 2024
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 18, 2024
timuthy
timuthy previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thank you!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2024
@LucaBernstein LucaBernstein force-pushed the nscpfl/10629/namespacedcloudprofile-providerConfig branch from b504bb3 to f4bbc23 Compare November 19, 2024 13:02
@gardener-robot gardener-robot added needs/review Needs review needs/second-opinion Needs second review by someone else and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Nov 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2024
@AndreasBurger AndreasBurger merged commit b18bd72 into gardener:master Nov 20, 2024
13 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 20, 2024
@LucaBernstein LucaBernstein deleted the nscpfl/10629/namespacedcloudprofile-providerConfig branch November 21, 2024 07:40
@LucaBernstein LucaBernstein mentioned this pull request Nov 21, 2024
Open
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

@timuthy timuthy timuthy left review comments

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else platform/azure Microsoft Azure platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LucaBernstein @AndreasBurger @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot