Update to go 1.23.3 #1005
Merged
Update to go 1.23.3 #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
kon-angelo
reviewed
Nov 11, 2024
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/gardener/gardener-extension-provider-azure | |||
|
|
|||
| go 1.23.0 | |||
| go 1.23.3 | |||
There was a problem hiding this comment.
Not sure about this change 🤔
There was a problem hiding this comment.
The go directive in the go.mod is the mininum go version needed to run the program. So, it should remain at 1.23.0 I believe
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
kon-angelo
reviewed
Nov 11, 2024
Dockerfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| ############# builder | |||
| FROM golang:1.23.0 AS builder | |||
| FROM golang:1.23 AS builder | |||
There was a problem hiding this comment.
Removing the patch version from the tests is great and it will make dependabot updates work out of the box for all specific go patch versions.
For the main images I think it's best to be very explicit
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
AndreasBurger
approved these changes
Nov 20, 2024
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
/platform azure
What this PR does / why we need it:
Update to go 1.23.3
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: